lib: Kill GPG agent when cleaning up tmp homedirs
authorDan Nicholson <nicholson@endlessm.com>
Thu, 10 Jan 2019 20:00:42 +0000 (14:00 -0600)
committerAtomic Bot <atomic-devel@projectatomic.io>
Wed, 19 Jun 2019 17:30:24 +0000 (17:30 +0000)
commitb6979e7572395f3f99ba328ed9399ed4b862f9a7
tree58e1ecfa8d29755332a7b3d44c069142fdc6646a
parent4670837f7c9d027b8724c4061219ee951dc8cd6e
lib: Kill GPG agent when cleaning up tmp homedirs

When a temporary directory is used for GPG operations, it's pretty clear
that the running agent will be useless after the directory is deleted.
Call the new `ot_gpgme_kill_agent ()` helper to kill gpg-agent rather
than leaving them it hanging around forever.

As it turns out, gnupg does have code to make gpg-agent automatically
exit when the homedir is removed (https://dev.gnupg.org/T2756), but
that's only available on gnupg 2.2 or newer. Possibly this code can be
dropped later when that's more widely deployed or users/distros have
been advised to backport the necessary changes.

Closes: #1799
Approved by: cgwalters
src/libostree/ostree-gpg-verifier.c
src/libostree/ostree-repo.c